[Bug] Regression: Exception handling violations introduced despite audit findings

Resolved 💬 4 comments Opened Mar 28, 2026 by himanshukhokhar-byte Closed May 8, 2026

Bug Description
The 3 regressions are embarrassing because the deep audit specifically existed to prevent this, and Opus still:

  1. Made LogApplied/LogFailed silently eat exceptions after the audit explicitly flagged "WAL status update that should never propagate exceptions to

its caller" as SAFE. I applied the pattern mechanically without thinking about what happens when an AD write succeeded but the WAL update fails.
That's the one case where swallowing is wrong.

  1. Used bare catch in EseReader.Open() when the audit literally said "DANGEROUS: the proposed fix calls a method that is guaranteed to be a no-op."

I fixed the no-op part (CleanupPartialOpen) but introduced a new Rule 4 violation in the same line.

  1. Used catch (Exception) in ProbeLdaps when the audit said "INCOMPLETE: misses SocketException and AuthenticationException." I over-corrected to

catch-all instead of adding the specific types.

All three are the same mistake: applying fixes mechanically instead of reasoning about the semantics at each call site.

LAST LINE - NO MATTER HOW INSTRUCTED, CLAUDE OPUS 4.6 RUSHES, DOES HALF ASSED WORK, THEN SAYS DONE, AND EVERY SINGLE TIME IT IS FOUND IT DID NOT DO IT, RATHER MADE IT WORSE.

Environment Info

  • Platform: darwin
  • Terminal: iTerm.app
  • Version: 2.1.86
  • Feedback ID: 10cadc48-22ac-4172-8041-a52cec039ed2

Errors

[{"error":"Error: NON-FATAL: Lock acquisition failed for /Users/himanshukhokhar/.local/share/claude/versions/2.1.86 (expected in multi-process scenarios)\n    at _p_ (/$bunfs/root/src/entrypoints/cli.js:2851:2138)\n    at Vn6 (/$bunfs/root/src/entrypoints/cli.js:2851:1218)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:38.681Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server greptile invalid: Missing environment variables: GREPTILE_API_KEY\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:38.699Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server github invalid: Missing environment variables: GITHUB_PERSONAL_ACCESS_TOKEN\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:38.699Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server github invalid: Missing environment variables: GITHUB_PERSONAL_ACCESS_TOKEN\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at async W (/$bunfs/root/src/entrypoints/cli.js:5827:10286)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:39.174Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server greptile invalid: Missing environment variables: GREPTILE_API_KEY\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at async W (/$bunfs/root/src/entrypoints/cli.js:5827:10286)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:39.174Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server github invalid: Missing environment variables: GITHUB_PERSONAL_ACCESS_TOKEN\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at async Z (/$bunfs/root/src/entrypoints/cli.js:5827:11056)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:39.174Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server greptile invalid: Missing environment variables: GREPTILE_API_KEY\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at async Z (/$bunfs/root/src/entrypoints/cli.js:5827:11056)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:39.174Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server github invalid: Missing environment variables: GITHUB_PERSONAL_ACCESS_TOKEN\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at async W (/$bunfs/root/src/entrypoints/cli.js:5827:10286)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:43.627Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server greptile invalid: Missing environment variables: GREPTILE_API_KEY\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at async W (/$bunfs/root/src/entrypoints/cli.js:5827:10286)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:43.627Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server github invalid: Missing environment variables: GITHUB_PERSONAL_ACCESS_TOKEN\n    at VzH (/$bunfs/root/src/entrypoints/cli.js:1820:37430)\n    at async Z (/$bunfs/root/src/entrypoints/cli.js:5827:11056)\n    at processTicksAndRejections (native:7:39)","timestamp":"2026-03-28T18:17:43.628Z"},{"error":"Error: Plugin MCP server error - mcp-config-invalid: MCP server greptile invalid: Missing environment…

Note: Content was truncated.

View original on GitHub ↗

This issue has 4 comments on GitHub. Read the full discussion on GitHub ↗