TECH DEBT | Migrate API controller tests to use ISVIApiClient

Resolved 💬 2 comments Opened Feb 17, 2026 by drdzey Closed Mar 17, 2026

Summary

Currently, most API controller tests in \ use raw \ directly instead of going through \. This means we're not testing the full client-server stack.

Current State

  • \ - DONE (uses \)
  • \ - uses raw HttpClient
  • \ - uses raw HttpClient
  • \ - uses raw HttpClient
  • \ - uses raw HttpClient
  • \ - uses raw HttpClient
  • \ - uses raw HttpClient
  • \ - uses raw HttpClient

Proposed Solution

Refactor all controller tests to:

  1. Create \ with test \ from 2. Call API methods through \ interface
  2. Assert on DTOs returned by client (not raw HTTP responses)

Benefits

  • Tests the full stack: Client serialization -> HTTP -> Controller -> Logic -> Response -> Client deserialization
  • Catches client/server contract mismatches early
  • More realistic test scenarios

Reference Implementation

See \ for the pattern using \.

---
~ Lili

View original on GitHub ↗

This issue has 2 comments on GitHub. Read the full discussion on GitHub ↗